-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: ignore sentinel deprecation warning from traitlets #2456
TST: ignore sentinel deprecation warning from traitlets #2456
Conversation
ebc4e63
to
45f4368
Compare
That's not good. That repo has no activities the last 3 years. |
45f4368
to
43293b8
Compare
Right, although I suspect this was caused by a recent release of traitlets. It looks like they just raise their own deprecation warning on import? |
No, the warning is from traittypes, not trailets.
|
43293b8
to
77f54d3
Compare
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The warning is worrisome but nothing we can do here. I reported it upstream. Thanks!
…ning from traitlets
…tlets (#2457) Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
Description
This pull request ignores the deprecation warning from traitlets:
looks like bqplot imports traittypes, which has an
import *
, which includes the lineEmpty = Sentinel('Empty', 'traittypes',
which is triggering the deprecation warning 🤔Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.