Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: ignore sentinel deprecation warning from traitlets #2456

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Sep 14, 2023

Description

This pull request ignores the deprecation warning from traitlets:

E   DeprecationWarning:
E               Sentinel is not a public part of the traitlets API.
E               It was published by mistake, and may be removed in the future.

looks like bqplot imports traittypes, which has an import *, which includes the line Empty = Sentinel('Empty', 'traittypes', which is triggering the deprecation warning 🤔

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added testing trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive 💤 backport-v3.6.x on-merge: backport to v3.6.x labels Sep 14, 2023
@kecnry kecnry added this to the 3.6.3 milestone Sep 14, 2023
@kecnry kecnry force-pushed the ignore-sentinel-deprecation branch 2 times, most recently from ebc4e63 to 45f4368 Compare September 14, 2023 13:08
@pllim
Copy link
Contributor

pllim commented Sep 14, 2023

That's not good. bqplot imports traittypes that causes this warning.

https://github.com/jupyter-widgets/traittypes/blob/af2ebeec9e58b73a12d4cf841bd506d6eadb8868/traittypes/traittypes.py#L21

That repo has no activities the last 3 years.

@kecnry kecnry force-pushed the ignore-sentinel-deprecation branch from 45f4368 to 43293b8 Compare September 14, 2023 13:13
@kecnry
Copy link
Member Author

kecnry commented Sep 14, 2023

Right, although I suspect this was caused by a recent release of traitlets. It looks like they just raise their own deprecation warning on import?

pyproject.toml Outdated Show resolved Hide resolved
@kecnry kecnry force-pushed the ignore-sentinel-deprecation branch from 43293b8 to 77f54d3 Compare September 14, 2023 13:27
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@kecnry kecnry marked this pull request as ready for review September 14, 2023 13:46
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning is worrisome but nothing we can do here. I reported it upstream. Thanks!

@kecnry kecnry merged commit aa9d142 into spacetelescope:main Sep 14, 2023
14 checks passed
@kecnry kecnry deleted the ignore-sentinel-deprecation branch September 14, 2023 13:50
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Sep 14, 2023
kecnry added a commit that referenced this pull request Sep 14, 2023
…tlets (#2457)

Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive testing trivial Only needs one approval instead of two 💤 backport-v3.6.x on-merge: backport to v3.6.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants