Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "TST: Ignore ASDF warning about gwcs-1.0.0 schema" #2463

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Sep 15, 2023

Reverts #2451 now that spacetelescope/gwcs#475 is merged upstream. 🤞

xref #2446

@pllim pllim added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive 💤 backport-v3.6.x on-merge: backport to v3.6.x labels Sep 15, 2023
@pllim pllim added this to the 3.6.3 milestone Sep 15, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
...daviz/configs/imviz/tests/test_astrowidgets_api.py 100.00%
jdaviz/configs/mosviz/tests/test_parsers.py 100.00%

📢 Thoughts on this report? Let us know!.

@pllim pllim marked this pull request as ready for review September 15, 2023 21:48
@pllim
Copy link
Contributor Author

pllim commented Sep 15, 2023

Thanks to @braingram , we no longer need to ignore the warnings!

@pllim pllim merged commit 29612cf into main Sep 15, 2023
21 checks passed
@pllim pllim deleted the revert-2451-fix-gwcs-schema-too-old branch September 15, 2023 21:49
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Sep 15, 2023
pllim added a commit that referenced this pull request Sep 15, 2023
…3-on-v3.6.x

Backport PR #2463 on branch v3.6.x (Revert "TST: Ignore ASDF warning about gwcs-1.0.0 schema")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imviz mosviz no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two 💤 backport-v3.6.x on-merge: backport to v3.6.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant