Revision of PR #1376 implementing the Solara FileBrowser #2467
+135
−445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file browser is more in line with the rest of the look and feel (not based on ipywidgets-controls, but on ipyvuetify). Also, looking at the comments at spacetelescope#573 this is implemented using: * Single click to select a directory or file * Import button for directory or file * Double click to quickly import a file. Tooltips are added to make clear what each button does, or why it is disabled. This requires solara >= 0.3
|
FYI, solara>=0.3.0 can now be replaces with |
kecnry
added a commit
to kecnry/jdaviz
that referenced
this pull request
Jun 5, 2024
Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1376 @maartenbreddels demo'ed the Solara file browser for jdaviz. The implementation in that PR is hard to test for two reasons:
FileChooserobject, but did not fully implement a solution for all of our uses ofFileChooser(note: this PR doesn't solve this problem)This PR gets the file browser working well enough to demonstrate @maartenbreddels's intended use case – replacing the backend on the
IMPORT DATAbutton – but does not fully implement all of theFrom file...buttons in plugins.This PR adds a simple/silly file validation step. The file browser will show directories in addition to files, and will only show files that are possible to load. For the purposes of this demo PR, I didn't create an exhaustive list of valid file extensions. We should ultimately connect this validation to the
get_valid_formatmethod to show the files compatible with this helper.