Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard shortcuts to see previous and next layer in plot options #2484

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

javerbukh
Copy link
Contributor

Description

This pull request is to add keyboard shortcuts 'd' and 'f' to select the previous and next viewer layer, respectively.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@github-actions github-actions bot added the imviz label Sep 27, 2023
@pllim pllim added this to the 3.8 milestone Sep 27, 2023
@pllim
Copy link
Contributor

pllim commented Sep 27, 2023

I don't remember any ticket for this.

And why "d" and "f"?

@kecnry
Copy link
Member

kecnry commented Sep 27, 2023

I can see how this would be convenient for long plugins like plot options, but maybe we should think about generalizing it across more/all plugins (and I worry about it being a keypress event on the viewer).

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Files Coverage Δ
jdaviz/configs/imviz/plugins/viewers.py 82.91% <7.69%> (-6.75%) ⬇️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@pllim
Copy link
Contributor

pllim commented Sep 27, 2023

Also, won't arrow keys be more intuitive?

@rosteen rosteen modified the milestones: 3.8, 3.9 Nov 29, 2023
@gibsongreen gibsongreen modified the milestones: 3.9, 3.10 Apr 5, 2024
@bmorris3 bmorris3 modified the milestones: 3.10, 3.11 May 3, 2024
@rosteen rosteen modified the milestones: 3.11, 4.1 Oct 17, 2024
@rosteen rosteen modified the milestones: 4.1, 4.2 Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants