Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preset palettes #2494

Merged
merged 5 commits into from
Oct 6, 2023
Merged

Preset palettes #2494

merged 5 commits into from
Oct 6, 2023

Conversation

javerbukh
Copy link
Contributor

Description

This pull request adds swatches to the color picker. The colors in the swatch were picked with consultation from OPO.

image

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@javerbukh javerbukh added the no-changelog-entry-needed changelog bot directive label Oct 4, 2023
@javerbukh javerbukh added this to the 3.7.1 milestone Oct 4, 2023
@pllim pllim added the imviz label Oct 4, 2023
@pllim
Copy link
Contributor

pllim commented Oct 4, 2023

Should fix the codestyle failure.

Does this need approval from PO?

Does the user facing doc need to be updated on how to best utilize this new feature and when does one need it?

@javerbukh
Copy link
Contributor Author

@pllim I assumed color pickers are pretty similar across applications, so I did not think we needed documentation. If you disagree I can add a section on how it works.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
...nfigs/default/plugins/plot_options/plot_options.py 83.10% <100.00%> (+0.09%) ⬆️

... and 5 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What an elegant solution! I didn't know I need this. I was skeptical at first but this shortcut is very nice when you can't be bothered to pick something from the full spectrum.

Need a change log though.

Do you think the user doc in Plot Options also need to be updated?

@pllim pllim added the 💤 backport-v3.7.x on-merge: backport to v3.7.x label Oct 6, 2023
@pllim
Copy link
Contributor

pllim commented Oct 6, 2023

Not technically a bug fix, do we need to backport?

Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me and I think this is a good incremental solution. Agreed that this should probably be mentioned in the changelog, doesn't qualify for a bugfix, but I don't see any need for documentation (at least not until it fits into the bigger picture for RGB workflows). It is self-discoverable and self-explanatory.

Would still like to see approval/comments from @PatrickOgle before merge though!

@javerbukh javerbukh removed the no-changelog-entry-needed changelog bot directive label Oct 6, 2023
@pllim pllim requested a review from PatrickOgle October 6, 2023 19:30
@pllim pllim modified the milestones: 3.7.1, 3.8 Oct 6, 2023
@pllim pllim removed the 💤 backport-v3.7.x on-merge: backport to v3.7.x label Oct 6, 2023
CHANGES.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Patrick doesn't use it, I will!

@javerbukh javerbukh merged commit 9f0b7a4 into spacetelescope:main Oct 6, 2023
14 checks passed
@javerbukh javerbukh deleted the preset-palettes branch October 6, 2023 20:10
Copy link
Contributor

@PatrickOgle PatrickOgle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is very elegant. Nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants