Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stretch histogram reset_limits #2529

Merged
merged 6 commits into from
Nov 16, 2023
Merged

Fix stretch histogram reset_limits #2529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
66e1046
Make sure that the stretch histogram has x_att set to 'x' for the his…
astrofrog Oct 24, 2023
58800cc
Fix PEP 8 warnings
pllim Oct 24, 2023
28485bd
Remove workarounds related to stretch histogram
astrofrog Oct 26, 2023
706db5b
Bump minimum required version of glue-core to v1.14.1 to include bug …
astrofrog Oct 26, 2023
5d26d9e
fix percentile and bins when resetting limits
kecnry Oct 31, 2023
ee38073
update glue-core pin
kecnry Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions jdaviz/configs/default/plugins/plot_options/plot_options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,15 +469,13 @@ def state_attr_for_line_visible(state):
self.stretch_histogram.tools_nested,
["jdaviz:stretch_bounds"])

# NOTE: this is a current workaround so the histogram viewer doesn't crash when replacing
# data. Note also that passing x=[0] fails on SOME machines, so we'll pass [0, 1] instead
self.stretch_histogram._add_data('ref', x=[0, 1])
self.stretch_histogram.layers['ref'].state.visible = False
self.stretch_histogram._add_data('histogram', x=[0, 1])

self.stretch_histogram.add_line('vmin', x=[0, 0], y=[0, 1], ynorm=True, color='#c75d2c')
self.stretch_histogram.add_line('vmax', x=[0, 0], y=[0, 1], ynorm='vmin', color='#c75d2c')
self.stretch_histogram.add_scatter('colorbar', x=[], y=[], ynorm='vmin', marker='square', stroke_width=33) # noqa: E501
self.stretch_histogram.viewer.state.update_bins_on_reset_limits = False
self.stretch_histogram.viewer.state.x_limits_percentile = 95
with self.stretch_histogram.figure.hold_sync():
self.stretch_histogram.figure.axes[0].label = 'pixel value'
self.stretch_histogram.figure.axes[0].num_ticks = 3
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ dependencies = [
"traitlets>=5.0.5",
"bqplot>=0.12.37",
"bqplot-image-gl>=1.4.11",
"glue-core>=1.14",
"glue-core>=1.16.0",
"glue-jupyter>=0.19",
"echo>=0.5.0",
"ipykernel>=6.19.4",
Expand Down