Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Explicitly set navigation_with_keys #2533

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Oct 25, 2023

Description

This pull request is to explicitly set navigation_with_keys to silence pydata-sphinx-theme warning that is failing RTD.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

to silence pydata-sphinx-theme warning that is failing RTD.
@pllim pllim added documentation Explanation of code and concepts trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive 💤 backport-v3.7.x on-merge: backport to v3.7.x labels Oct 25, 2023
@pllim pllim added this to the 3.7.1 milestone Oct 25, 2023
@pllim pllim marked this pull request as ready for review October 25, 2023 17:10
Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@pllim pllim mentioned this pull request Oct 25, 2023
10 tasks
@rosteen
Copy link
Collaborator

rosteen commented Oct 25, 2023

This only affects docs, we can probably skip the rest of the checks and merge.

@pllim
Copy link
Contributor Author

pllim commented Oct 25, 2023

Up to you. 😉

@rosteen rosteen merged commit b36b3ed into spacetelescope:main Oct 25, 2023
21 of 22 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Oct 25, 2023
@pllim pllim deleted the fix-rtd-again branch October 25, 2023 17:13
rosteen pushed a commit that referenced this pull request Oct 25, 2023
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
rosteen pushed a commit to rosteen/jdaviz that referenced this pull request Oct 25, 2023
…keys (spacetelescope#2534)

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Explanation of code and concepts no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two 💤 backport-v3.7.x on-merge: backport to v3.7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants