-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove warning filters that are no longer needed for testing #2536
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 3 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
Marking this trivial since the only requirement is that the tests pass. Not sure how this affected coverage, I think Codecov is hallucinating. |
@@ -127,26 +127,12 @@ text_file_format = "rst" | |||
addopts = "--doctest-rst --import-mode=append" | |||
filterwarnings = [ | |||
"error", | |||
"ignore:numpy\\.ufunc size changed:RuntimeWarning", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to keep the ufunc one. It comes up once in a while depending on how CI installed stuff and in what order.
I think you removed too many...
|
Blast. I'll come back to this tomorrow, I was testing locally but didn't have all the dev dependencies. |
Thanks for tackling this! |
Temporarily remove a few tests Put these back
5003c24
to
fbbf77b
Compare
The 3.12 dev test now hits a real error from |
Yeah probably save us time to just wait out the pandamonium. |
Just merged in pandas-dev/pandas#55707 so hopefully this should show up in tomorrow's wheels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
devdeps is green now. LGTM. Thanks for knocking out a bunch of these ignores!
Does what it says on the tin.