Don't try to update viewer state if it was deleted #2541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosteen
added
bug
rosteen
requested review from
javerbukh,
pllim,
kecnry,
bmorris3,
haticekaratay and
cshanahan1
as code owners
|
Add a test? 😉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
kecnry
reviewed
Oct 31, 2023
No. ...ok, fiiine 😆 |
kecnry
approved these changes
Nov 1, 2023
rosteen
force-pushed
the
let-it-go-plot-options
branch
from
b09a311 to
933650d
Compare
|
I'm having trouble writing a test that fails on Edit: wait, I lied, in the notebook I was using real images linked by WCS rather than the numpy arrays. If I load the numpy arrays in the notebook it doesn't error 🤔. |
|
As discussed offline, going to merge this rather than spending a bunch more time figuring out a test that fails on |
meeseeksmachine
pushed a commit
to meeseeksmachine/jdaviz
that referenced
this pull request
Nov 1, 2023
pllim
added a commit
that referenced
this pull request
Nov 1, 2023
…1-on-v3.7.x Backport PR #2541 on branch v3.7.x (Don't try to update viewer state if it was deleted)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2521 , turned out to be very simple once I tracked it down. This was previously causing an error if the viewer was deleted, since
Nonehas nostate.