Proof of Concept: Save and reload Glue-related states and data. #2552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pllim
reviewed
Nov 3, 2023
| for layer_id, layer_dict in saved_viewer_state['layers'].items(): | ||
| data_label = layer_id.split(" ")[0] | ||
| if data_label not in self.data_collection.labels: | ||
| print(f"Couldn't find or load {data_label}.") |
There was a problem hiding this comment.
I know this is just POC, but hopefully you do not plan to keep this print?
There was a problem hiding this comment.
I had hoped that would be obvious.
There was a problem hiding this comment.
The continue threw me off. I am not sure if you want some sort of logging here permanently or not.
There was a problem hiding this comment.
Probably would make this a snackbar message, assuming restore_state gets a button in the UI.
pllim
reviewed
Nov 3, 2023
That's a good idea. Plenty of other stuff that still could/needs to go in this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of to-do's left, but this shows off a proof of concept for saving and restoring state, including automatically loading the same data as long as it's on disk (currently just prints a warning if objects had been loaded and weren't reloaded prior to restoring state). Demo video attached, I've only tested with Imviz so far.
Screen.Recording.2023-11-03.at.11.31.00.AM.mov