Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Adjust threshold for codecov patch to be non-zero #2561

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Nov 10, 2023

Description

This pull request is to address codecov now setting patch threshold to zero in PRs, rendering patch coverage meaningless.

https://docs.codecov.com/docs/commit-status#patch-status

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Nov 10, 2023
@pllim pllim added this to the 3.8 milestone Nov 10, 2023
Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@pllim
Copy link
Contributor Author

pllim commented Nov 10, 2023

Thank me after we actually see it works... 😅

You're welcome.

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 160 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

@pllim
Copy link
Contributor Author

pllim commented Nov 10, 2023

I cannot tell from the status that comes back to this PR. 🤷

Screenshot 2023-11-10 144033

@pllim pllim marked this pull request as ready for review November 10, 2023 19:41
@pllim pllim merged commit dc09c8e into spacetelescope:main Nov 10, 2023
19 checks passed
@pllim pllim deleted the patch-codecov-patch-code branch November 10, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants