Allow change in cmap_att on change in data components #2567
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Glue scatter viewers plot 2D scatter points, with an option for custom sizes and colors, mapped onto any of the glue
Data
's components. In order for this to work correctly, the glueComponentIDComboHelper
s like thecmap_att_helper
, which can be found atviewer.layers[0].state.cmap_att_helper
, must have a list ofchoices
which are in sync with all of that layer'sData
components. If components can be added or renamed, the component choices withinPlotOptionsSyncState
should be updated. I was using this feature in LCviz today, and I found that those component choices do not get updated (😱).I traced the problem back to one line, and implemented a fix in this PR. No one will see any difference in jdaviz (until we use more scatter viewers in the near[?] future!), but this PR enables features that are implemented but not working in LCviz.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.