-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin-action-button component for consistent styling #2571
Conversation
* better consistency for coloring by passing :results_isolated_to_plugin="true/false" * update UI style guide * adds spinner for "Calculate" button in aperture photometry, "Search" in catalogs, and "Apply RGB Presets" in plot options
3d667be
to
cf98367
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2571 +/- ##
==========================================
- Coverage 90.80% 90.80% -0.01%
==========================================
Files 160 160
Lines 19394 19396 +2
==========================================
+ Hits 17611 17612 +1
- Misses 1783 1784 +1 ☔ View full report in Codecov by Sentry. |
This looks good to me so far but I want to do just a little more testing (I did Imviz but not Specviz) in the morning before hitting Approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me after the one suggestion I left above.
Co-authored-by: Ricky O'Steen <39831871+rosteen@users.noreply.github.com>
…#2571) * create new <plugin-action-button> component * better consistency for coloring by passing :results_isolated_to_plugin="true/false" * update UI style guide * adds spinner for "Calculate" button in aperture photometry, "Search" in catalogs, and "Apply RGB Presets" in plot options
Description
This pull request creates a new
plugin-action-button
UI component for more developer-friendly consistent-styling of buttons in plugins.:results_isolated_to_plugin="true/false"
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.