Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin-action-button component for consistent styling #2571

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Nov 20, 2023

Description

This pull request creates a new plugin-action-button UI component for more developer-friendly consistent-styling of buttons in plugins.

  • better consistency for coloring by passing :results_isolated_to_plugin="true/false"
  • update UI style guide
  • adds spinner for "Calculate" button in aperture photometry, "Search" in catalogs, and "Apply RGB Presets" in plot options (previously wasn't available because the spinner logic from plugins: disable action button while computing #2560 was isolated to add-results components)
  • changes color of buttons in subset plugin since clicking them affects the app itself

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added UI/UX😍 trivial Only needs one approval instead of two labels Nov 20, 2023
@kecnry kecnry added this to the 3.8 milestone Nov 20, 2023
@github-actions github-actions bot added documentation Explanation of code and concepts imviz labels Nov 20, 2023
* better consistency for coloring by passing :results_isolated_to_plugin="true/false"
* update UI style guide
* adds spinner for "Calculate" button in aperture photometry, "Search" in catalogs, and "Apply RGB Presets" in plot options
@kecnry kecnry marked this pull request as ready for review November 20, 2023 14:33
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac3078a) 90.80% compared to head (cf98367) 90.80%.
Report is 1 commits behind head on main.

❗ Current head cf98367 differs from pull request most recent head 4e9d41e. Consider uploading reports for the commit 4e9d41e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2571      +/-   ##
==========================================
- Coverage   90.80%   90.80%   -0.01%     
==========================================
  Files         160      160              
  Lines       19394    19396       +2     
==========================================
+ Hits        17611    17612       +1     
- Misses       1783     1784       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rosteen
Copy link
Collaborator

rosteen commented Nov 21, 2023

This looks good to me so far but I want to do just a little more testing (I did Imviz but not Specviz) in the morning before hitting Approve.

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me after the one suggestion I left above.

Co-authored-by: Ricky O'Steen <39831871+rosteen@users.noreply.github.com>
@kecnry kecnry enabled auto-merge (squash) November 22, 2023 14:38
@kecnry kecnry merged commit be28971 into spacetelescope:main Nov 22, 2023
12 of 13 checks passed
@kecnry kecnry deleted the moar-spinning branch November 22, 2023 14:51
rosteen pushed a commit to rosteen/jdaviz that referenced this pull request Nov 29, 2023
…#2571)

* create new <plugin-action-button> component
* better consistency for coloring by passing :results_isolated_to_plugin="true/false"
* update UI style guide
* adds spinner for "Calculate" button in aperture photometry, "Search" in catalogs, and "Apply RGB Presets" in plot options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Explanation of code and concepts imviz trivial Only needs one approval instead of two UI/UX😍
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants