Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #2771 on branch v3.10.x (Speed up histogram in plot options (alternative to #2763)) #2863

Conversation

meeseeksmachine
Copy link

Backport PR #2771: Speed up histogram in plot options (alternative to #2763)

@lumberbot-app lumberbot-app bot added this to the 3.10.1 milestone May 8, 2024
@lumberbot-app lumberbot-app bot added imviz Ready for final review performance Performance related plugin Label for plugins common to multiple configurations 💤backport-v3.10.x on-merge: backport to v3.10.x labels May 8, 2024
@pllim
Copy link
Contributor

pllim commented May 8, 2024

Actually, do we want to bump glue and glue-jupyter minversions in backport? If not, maybe we don't have to backport this?

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.96%. Comparing base (bf4c599) to head (8ae01ee).
Report is 53 commits behind head on v3.10.x.

Files with missing lines Patch % Lines
...nfigs/default/plugins/plot_options/plot_options.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           v3.10.x    #2863      +/-   ##
===========================================
+ Coverage    88.93%   88.96%   +0.02%     
===========================================
  Files          111      111              
  Lines        17165    17155      -10     
===========================================
- Hits         15266    15262       -4     
+ Misses        1899     1893       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rosteen
Copy link
Collaborator

rosteen commented May 14, 2024

Actually, do we want to bump glue and glue-jupyter minversions in backport? If not, maybe we don't have to backport this?

I'm about to do a bugfix release, I'm fine deferring this personally. I can move it to 3.10.2 milestone if we want to think about it more.

@pllim
Copy link
Contributor

pllim commented May 14, 2024

Let's defer. I don't see any rush. Thanks!

@rosteen rosteen modified the milestones: 3.10.1, 3.10.2 May 14, 2024
@pllim pllim closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imviz performance Performance related plugin Label for plugins common to multiple configurations Ready for final review 💤backport-v3.10.x on-merge: backport to v3.10.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants