Un-ignore GWCS warning because it is no longer necessary #3290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pllim
added
trivial
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3290 +/- ##
==========================================
- Coverage 88.80% 88.80% -0.01%
==========================================
Files 125 125
Lines 19119 19117 -2
==========================================
- Hits 16979 16977 -2
Misses 2140 2140 ☔ View full report in Codecov by Sentry. |
because we can not ignore warnings now.
pllim
force-pushed
the
revert-ignore-gwcs-warn
branch
from
4879765 to
85caeaa
Compare
pllim
changed the title
pllim
requested review from
rosteen,
javerbukh,
kecnry,
bmorris3,
haticekaratay,
cshanahan1 and
gibsongreen
as code owners
|
This is ready now for merge. FYI. |
kecnry
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See if spacetelescope/gwcs#526 works so we do not have to worry about warning from bounding box downstream anymore in cases we cannot control.
Reverts parts of #3283