Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subset tools import_region to use batch_load #3321

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Nov 27, 2024

Description

This pull request delays loading subset layers into viewers during subset tools import_region until all regions are loaded into the data collection, improving performance considerably.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added the performance Performance related label Nov 27, 2024
@kecnry kecnry added this to the 4.1 milestone Nov 27, 2024
@github-actions github-actions bot added the plugin Label for plugins common to multiple configurations label Nov 27, 2024
@kecnry kecnry force-pushed the batch-plugin-add-results branch from 0f685b4 to e62671b Compare November 27, 2024 14:37
@kecnry kecnry marked this pull request as ready for review November 27, 2024 18:05
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 92.98246% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.82%. Comparing base (3dc6573) to head (ea9deba).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...nfigs/default/plugins/subset_tools/subset_tools.py 92.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3321   +/-   ##
=======================================
  Coverage   88.81%   88.82%           
=======================================
  Files         125      125           
  Lines       19041    19044    +3     
=======================================
+ Hits        16912    16915    +3     
  Misses       2129     2129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gibsongreen gibsongreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me and the speed up is very noticeable, this'll be very nice to use with this use case!

Copy link
Contributor

@javerbukh javerbukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I agree that there is a noticeable speed up, thanks!

@kecnry kecnry merged commit 9ab6607 into spacetelescope:main Dec 5, 2024
25 checks passed
@kecnry kecnry deleted the batch-plugin-add-results branch December 5, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance related plugin Label for plugins common to multiple configurations Ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants