-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subsets tools API hints #3325
Subsets tools API hints #3325
Conversation
ad6b7f7
to
f726688
Compare
0dd88e4
to
02cdf8c
Compare
02cdf8c
to
20e7aa7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3325 +/- ##
=======================================
Coverage 88.80% 88.80%
=======================================
Files 125 125
Lines 19119 19137 +18
=======================================
+ Hits 16978 16994 +16
- Misses 2141 2143 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
@@ -53,10 +69,25 @@ | |||
:selected.sync="dataset_selected" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be
:items="recenter_dataset_items"
:selected.sync="recenter_dataset_selected"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(thank you @haticekaratay for pointing out that the UI was broken after recentering via API)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch 😬 should be fixed now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @cshanahan1, for making the post. That was the only thing I had seen as well; everything else looks good to me. Thank you, @kecnry, for your work!
Description
This pull request exposes
recenter_dataset
andrecenter()
and adds API hints for the subset tools plugin.Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.