Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsets tools API hints #3325

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Dec 2, 2024

Description

This pull request exposes recenter_dataset and recenter() and adds API hints for the subset tools plugin.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added this to the 4.1 milestone Dec 2, 2024
@github-actions github-actions bot added the plugin Label for plugins common to multiple configurations label Dec 2, 2024
@kecnry kecnry force-pushed the subsets-api-hints branch from ad6b7f7 to f726688 Compare December 2, 2024 19:55
@kecnry kecnry marked this pull request as ready for review December 2, 2024 20:06
@kecnry kecnry force-pushed the subsets-api-hints branch from 0dd88e4 to 02cdf8c Compare December 2, 2024 20:50
@kecnry kecnry force-pushed the subsets-api-hints branch from 02cdf8c to 20e7aa7 Compare December 2, 2024 21:06
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.80%. Comparing base (81e940d) to head (0be5251).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...nfigs/default/plugins/subset_tools/subset_tools.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3325   +/-   ##
=======================================
  Coverage   88.80%   88.80%           
=======================================
  Files         125      125           
  Lines       19119    19137   +18     
=======================================
+ Hits        16978    16994   +16     
- Misses       2141     2143    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cshanahan1 cshanahan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@@ -53,10 +69,25 @@
:selected.sync="dataset_selected"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be
:items="recenter_dataset_items"
:selected.sync="recenter_dataset_selected"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(thank you @haticekaratay for pointing out that the UI was broken after recentering via API)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 😬 should be fixed now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @cshanahan1, for making the post. That was the only thing I had seen as well; everything else looks good to me. Thank you, @kecnry, for your work!

@kecnry kecnry merged commit 1a7d932 into spacetelescope:main Dec 5, 2024
19 checks passed
@kecnry kecnry deleted the subsets-api-hints branch December 5, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin Label for plugins common to multiple configurations Ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants