Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing filter warning for mpl-scatter-density #3327

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

bmorris3
Copy link
Contributor

@bmorris3 bmorris3 commented Dec 3, 2024

Description

The filtered warning for mpl-scatter-density may be unnecessary since the release of v0.8. Trying that out in this PR.

It turns out that there was an in situ pkg_resources warning stemming from linelists.py, too.

Related PRs:

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@bmorris3 bmorris3 added this to the 4.0.1 milestone Dec 3, 2024
@bmorris3 bmorris3 added the no-changelog-entry-needed changelog bot directive label Dec 3, 2024
@rosteen
Copy link
Collaborator

rosteen commented Dec 3, 2024

Looks like you realized linelists.py was causing problems at the same time I did. This looks good, what's stopping you from moving it out of draft? I would like to see CI passing on some other PRs.

Edit: Oh, right, this is removing the ignore not adding it. Could you split the linelists.py fix out to a separate PR that we can merge now?

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.80%. Comparing base (81e940d) to head (ca6cc6e).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3327   +/-   ##
=======================================
  Coverage   88.80%   88.80%           
=======================================
  Files         125      125           
  Lines       19119    19119           
=======================================
+ Hits        16978    16979    +1     
+ Misses       2141     2140    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmorris3 bmorris3 marked this pull request as ready for review December 3, 2024 16:01
@bmorris3
Copy link
Contributor Author

bmorris3 commented Dec 3, 2024

@rosteen both fixes are ready to go in this PR pending reviews.

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, I didn't realize that Tom just did that release. Approved, thanks!

@rosteen
Copy link
Collaborator

rosteen commented Dec 3, 2024

IMHO we could mark this trivial and get it in 🤷

@rosteen rosteen merged commit 3f1abf7 into spacetelescope:main Dec 3, 2024
19 checks passed
@rosteen rosteen added the backport-v4.0.x on-merge: backport to v4.0.x label Dec 11, 2024
rosteen pushed a commit to rosteen/jdaviz that referenced this pull request Dec 11, 2024
* removing filter warning for mpl-scatter-density

* replace deprecated pkg_resources call in linelists

(cherry picked from commit 3f1abf7)
@rosteen rosteen removed the backport-v4.0.x on-merge: backport to v4.0.x label Dec 11, 2024
@rosteen
Copy link
Collaborator

rosteen commented Dec 11, 2024

Forgot to add the backport label to this, I cherry-picked the commit into #3348.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants