-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing filter warning for mpl-scatter-density #3327
Conversation
Looks like you realized Edit: Oh, right, this is removing the ignore not adding it. Could you split the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3327 +/- ##
=======================================
Coverage 88.80% 88.80%
=======================================
Files 125 125
Lines 19119 19119
=======================================
+ Hits 16978 16979 +1
+ Misses 2141 2140 -1 ☔ View full report in Codecov by Sentry. |
@rosteen both fixes are ready to go in this PR pending reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, I didn't realize that Tom just did that release. Approved, thanks!
IMHO we could mark this trivial and get it in 🤷 |
* removing filter warning for mpl-scatter-density * replace deprecated pkg_resources call in linelists (cherry picked from commit 3f1abf7)
Forgot to add the backport label to this, I cherry-picked the commit into #3348. |
Description
The filtered warning for
mpl-scatter-density
may be unnecessary since the release of v0.8. Trying that out in this PR.It turns out that there was an in situ
pkg_resources
warning stemming fromlinelists.py
, too.Related PRs:
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.