Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model fitting: ensure specutils has access to equivs & set targ solid angle #3343

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gibsongreen
Copy link
Contributor

@gibsongreen gibsongreen commented Dec 9, 2024

This draft PR resolves:

  1. UnitConversionError in Model Fitting plugin, specutils spec.with_flux_unit did not have access to pix2 custom unit equivalencies

To reproduce on main:

uri ='https://data.science.stsci.edu/redirect/JWST/jwst-data_analysis_tools/IFU_cube_continuum_fit/NGC4151_Hband.fits'

model = cubeviz.plugins['Model Fitting']
model.cube_fit = True
model.create_model_component()
model.calculate_fit()
  1. TypeError: unsupported operand type(s) for *: 'CompositeUnit' and 'NoneType'. When toggling 'Cube Fit' in Model Fitting plugin, solid_angle_in_targ was not being set after targ_units was update to include a solid angle unit. Setting 'targ_units' triggered subsequent indirect conversion logic. By setting the solid_angle_in_targ we follow the same logic route and ensure we maintain output units in surface brightness.

To reproduce:

# example notebook cube
uri = "mast:JWST/product/jw02732-o004_t004_miri_ch1-shortmediumlong_s3d.fits"

uc = cubeviz.plugins['Unit Conversion']
uc.flux_unit = 'erg / (Angstrom s cm2)'

model = cubeviz.plugins['Model Fitting']
model.cube_fit = True
model.create_model_component()
model.calculate_fit()

Description

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@github-actions github-actions bot added the plugin Label for plugins common to multiple configurations label Dec 9, 2024
@gibsongreen gibsongreen added this to the 4.1 milestone Dec 9, 2024
@gibsongreen gibsongreen added bug Something isn't working cubeviz labels Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.80%. Comparing base (6c946d3) to head (ed72509).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3343   +/-   ##
=======================================
  Coverage   88.80%   88.80%           
=======================================
  Files         125      125           
  Lines       19137    19158   +21     
=======================================
+ Hits        16995    17014   +19     
- Misses       2142     2144    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gibsongreen gibsongreen changed the title model fitting: ensure specutils has access to custom equivs and update targ solid angle model fitting: ensure specutils has access to equivs & set targ solid angle Dec 11, 2024
@gibsongreen gibsongreen marked this pull request as ready for review December 11, 2024 22:59
@gibsongreen gibsongreen added the trivial Only needs one approval instead of two label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cubeviz plugin Label for plugins common to multiple configurations trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant