Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #3353 on branch v4.0.x (roman_datamodels compatibility, move romandeps test to CI workflows) #3357

Merged

Conversation

bmorris3
Copy link
Contributor

… (#3353)

  • rdm compatibility, move romandeps test to CI workflows

  • Fix ci_workflows.yml


Co-authored-by: P. L. Lim 2090236+pllim@users.noreply.github.com
(cherry picked from commit 05e9afb)

Description

This pull request is to address ...

Fixes #

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

…spacetelescope#3353)

* rdm compatibility, move romandeps test to CI workflows

* Fix ci_workflows.yml

---------

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
(cherry picked from commit 05e9afb)
@bmorris3 bmorris3 added this to the 4.0.1 milestone Dec 13, 2024
@github-actions github-actions bot added testing plugin Label for plugins common to multiple configurations rampviz labels Dec 13, 2024
@bmorris3 bmorris3 added the no-changelog-entry-needed changelog bot directive label Dec 13, 2024
@kecnry

This comment was marked as outdated.

@kecnry kecnry closed this Dec 13, 2024
@bmorris3 bmorris3 reopened this Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.62%. Comparing base (d975cfa) to head (de0855c).
Report is 5 commits behind head on v4.0.x.

Files with missing lines Patch % Lines
jdaviz/configs/rampviz/plugins/parsers.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           v4.0.x    #3357      +/-   ##
==========================================
- Coverage   88.64%   88.62%   -0.03%     
==========================================
  Files         125      125              
  Lines       18795    18819      +24     
==========================================
+ Hits        16661    16678      +17     
- Misses       2134     2141       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry merged commit be5caf3 into spacetelescope:v4.0.x Dec 13, 2024
25 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations rampviz testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants