Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding v4.0 of Thermal Curve #27

Merged
merged 6 commits into from
Jul 16, 2024

Conversation

mfixstsci
Copy link
Collaborator

No description provided.

@pep8speaks
Copy link

pep8speaks commented Jul 15, 2024

Hello @mfixstsci, Thank you for updating !

Line 169:14: E225 missing whitespace around operator
Line 304:26: E126 continuation line over-indented for hanging indent

Comment last updated at 2024-07-16 19:41:32 UTC

@mfixstsci mfixstsci changed the title Adding v4.0 of Thermal Curve DO NOT MERGE: Adding v4.0 of Thermal Curve Jul 15, 2024
@mfixstsci
Copy link
Collaborator Author

Wow -- okay looks like the CI is still running python versions that are extremely deprecated 😓 let me make some updates that we should merge in first. Will tag them here.

@mfixstsci mfixstsci mentioned this pull request Jul 15, 2024
@mfixstsci
Copy link
Collaborator Author

@bholler went ahead and added some updates to the CHANGES file to reflect changes in our next release (v1.3.0)

@bholler
Copy link

bholler commented Jul 16, 2024

@mfixstsci Did you mean to put "Cycle 3" in the CHANGES file?

@mfixstsci
Copy link
Collaborator Author

@bholler HA! See that's what happens when I follow whats in the changes file instead of checking the CfP timeline. I went ahead and updated to cycle 4 😅 I am also going to make one more push when we are ready to release with the date so I can make sure that doesn't happen again.

@mfixstsci mfixstsci changed the base branch from master to develop July 16, 2024 19:40
@mfixstsci mfixstsci changed the title DO NOT MERGE: Adding v4.0 of Thermal Curve Adding v4.0 of Thermal Curve Jul 16, 2024
@mfixstsci mfixstsci merged commit e2667a2 into spacetelescope:develop Jul 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants