temporarily remove jdaviz from devdeps #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* we're currently pinning a minor version of jdaviz and handling updates manually, so want to test that version of jdaviz with other devdeps
rosteen
approved these changes
Mar 28, 2024
|
Seems like a good plan for now. |
This was referenced Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently pinning a minor version of jdaviz and handling updates manually, so want to test that version of jdaviz with other devdeps (so a break caused by jdaviz does not prevent us from testing the other devdeps). Updating the pin to the next minor version of jdaviz is currently handled by PRs that bump the version and apply any necessary changes (i.e. #68) which will then ensure tests pass before bumping the minor version of jdaviz.
If we ever stop tagging a specific minor version, dev tests for jdaviz should be re-introduced (as mentioned in the added comment in
pyproject.toml)