Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override plugin links #43

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Sep 1, 2023

This PR overrides the links to jdaviz docs in plugins we inherit with those in the lcviz docs (which in turn can - and should - point to the upstream docs when appropriate).

Although not required to be released/pinned merge, this requires spacetelescope/jdaviz#2416 in order to see the overrides in the app, and #42 in order for all links to actually be built on the lcviz RTD.

I'll leave in draft until a decision is made on the jdaviz PR, but once that is merged, this can be merged and will just not be visible for anyone using an older version of jdaviz, and will eventually be visible to anyone once jdaviz 3.7 is released and pinned here.

Closes #9

@kecnry kecnry marked this pull request as ready for review September 1, 2023 14:50
@kecnry kecnry force-pushed the override-plugin-links branch 2 times, most recently from 9716367 to 517a139 Compare September 1, 2023 14:56
* to point to lcviz docs instead of jdaviz
@kecnry kecnry force-pushed the override-plugin-links branch from 517a139 to 163b418 Compare September 1, 2023 15:10
@kecnry kecnry merged commit 4d84dd8 into spacetelescope:main Sep 1, 2023
8 of 9 checks passed
@kecnry kecnry deleted the override-plugin-links branch September 1, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"learn more" links in plugins point to jdaviz docs
1 participant