Use upstream updates to plugin plots #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kecnry
added
the
waiting-on-jdaviz-release
kecnry
force-pushed
the
upstream-plugin-plots-to-viewer
branch
from
ac76c8c to
d03f949
Compare
wasn't failing before because jdaviz didn't enforce not setting non-exposed attributes
kecnry
force-pushed
the
upstream-plugin-plots-to-viewer
branch
from
90d2d51 to
c19297b
Compare
kecnry
removed
the
waiting-on-jdaviz-release
bmorris3
reviewed
Nov 30, 2023
| self.plot.figure.axes[1].label = 'power' | ||
| self.plot.figure.fig_margin = {'top': 60, 'bottom': 60, 'left': 65, 'right': 15} |
There was a problem hiding this comment.
Correction: the line above is not responsible for the figure/viewer axis label spacing.
There was a problem hiding this comment.
let's address the main viewer padding separately. It may be hard to get right in general, especially with such a large possible range in flux values.
bmorris3
approved these changes
Nov 30, 2023
bmorris3
pushed a commit
to bmorris3/lcviz
that referenced
this pull request
Dec 8, 2023
* update freq analysis plot to use glue-viewers * improve axes styling/padding (in plugin plots) * update jdaviz pin to 3.8 * update tests * add binning.show_live_preview to user-api (wasn't failing before because jdaviz didn't enforce not setting non-exposed attributes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the plot in frequency analysis to account for changes upstream in spacetelescope/jdaviz#2498 (which adds tool and pan/zoom support), and in doing so requires jdaviz 3.8.
Note that this also means that without this PR, the former implementation may be broken once jdaviz 3.8 is released.
Waiting for: jdaviz 3.8