make use of with_spinner decorator #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kecnry
added
the
waiting-on-jdaviz-release
kecnry
force-pushed
the
better-large-data-upstream-updates
branch
from
8925e02 to
54ca674
Compare
kecnry
force-pushed
the
better-large-data-upstream-updates
branch
from
54ca674 to
0c30fa8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
==========================================
- Coverage 95.04% 95.03% -0.02%
==========================================
Files 32 32
Lines 1393 1389 -4
==========================================
- Hits 1324 1320 -4
Misses 69 69 ☔ View full report in Codecov by Sentry. |
kecnry
removed
the
waiting-on-jdaviz-release
kecnry
force-pushed
the
better-large-data-upstream-updates
branch
from
164b79e to
4ac3ab6
Compare
this requires spacetelescope/jdaviz#2560
kecnry
force-pushed
the
better-large-data-upstream-updates
branch
from
4ac3ab6 to
5ffe80d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this updates #56
(and should be rebased once that is merged)to make use of the upstream implementation in spacetelescope/jdaviz#2560,but is blocked by that upstream PR being merged, released, and the jdaviz pin updated here (otherwise the imports will fail).Waiting for: jdaviz 3.8