Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cloned phase-viewers when deleting/renaming an ephemeris component #91

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Feb 23, 2024

Previously cloned phase-viewers (introduced in #74, not yet in a release) were not updated (renamed or removed) when an ephemeris component was renamed. This PR updates the ephemeris plugin to be aware that there may be multiple phase-viewers corresponding to the ephemeris, and treats the "first" as the default when assigning defaults based on axes limits, etc.

(ignore the crashing time plot - too many notebooks running at once)

Screen.Recording.2024-02-23.at.2.26.45.PM.mov

devdeps failure is likely because of jdaviz, but we are still pinned to jdaviz 3.8 (and those tests are passing). See #92 and #68.

@kecnry kecnry requested a review from bmorris3 February 23, 2024 19:24
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.18%. Comparing base (ca0efe9) to head (26fc524).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   93.92%   94.18%   +0.26%     
==========================================
  Files          35       35              
  Lines        1547     1548       +1     
==========================================
+ Hits         1453     1458       +5     
+ Misses         94       90       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry marked this pull request as ready for review February 23, 2024 19:27
@kecnry kecnry added the bug Something isn't working label Feb 23, 2024
Copy link
Contributor

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the behavior on main and with this, definitely looks better now.

@kecnry kecnry merged commit db3548d into spacetelescope:main Feb 26, 2024
10 of 11 checks passed
@kecnry kecnry deleted the fix-delete-ephem-cloned-viewer branch February 26, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants