Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecated call to importlib_resources.path causing downstream test failures #360

Closed
bmorris3 opened this issue Nov 27, 2024 · 0 comments · Fixed by #361
Closed

deprecated call to importlib_resources.path causing downstream test failures #360

bmorris3 opened this issue Nov 27, 2024 · 0 comments · Fixed by #361

Comments

@bmorris3
Copy link
Contributor

pysiaf uses importlib_resources.path here:

pysiaf/pysiaf/iando/read.py

Lines 644 to 645 in f2cd70e

with importlib_resources.path('pysiaf.prd_data.Roman',
'roman_siaf.xml') as siaf_file:

which has been deprecated, causing errors downstream of pysiaf in jdaviz, first noticed in spacetelescope/jdaviz#3322.

For details on using the files() API, see here: https://importlib-resources.readthedocs.io/en/latest/using.html#migrating-from-legacy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix deprecation warnings from importlib and numpy bmorris3/pysiaf
1 participant
@bmorris3