-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WFI footprint to Footprints plugin #3322
Conversation
3b5147a
to
b71bba8
Compare
b71bba8
to
7f9e90b
Compare
The test failure is an issue upstream: spacetelescope/pysiaf#360 |
Upstream issue should be resolved by: spacetelescope/pysiaf#361 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks! Follow-up effort for filtering to individual observatories coming soon.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3322 +/- ##
==========================================
- Coverage 88.81% 88.80% -0.02%
==========================================
Files 125 125
Lines 19041 19129 +88
==========================================
+ Hits 16912 16988 +76
- Misses 2129 2141 +12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks!
Description
Add support for Roman WFI (± CGI) footprints, implemented upstream in spacetelescope/pysiaf#333.
imviz-wfi-demo.mov
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.