Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WFI footprint to Footprints plugin #3322

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

bmorris3
Copy link
Contributor

@bmorris3 bmorris3 commented Nov 27, 2024

Description

Add support for Roman WFI (± CGI) footprints, implemented upstream in spacetelescope/pysiaf#333.

imviz-wfi-demo.mov

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

@github-actions github-actions bot added imviz plugin Label for plugins common to multiple configurations labels Nov 27, 2024
@bmorris3 bmorris3 added this to the 4.1 milestone Nov 27, 2024
@bmorris3
Copy link
Contributor Author

The test failure is an issue upstream: spacetelescope/pysiaf#360

@bmorris3
Copy link
Contributor Author

Upstream issue should be resolved by: spacetelescope/pysiaf#361

@bmorris3 bmorris3 marked this pull request as ready for review November 27, 2024 21:25
Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks! Follow-up effort for filtering to individual observatories coming soon.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.80%. Comparing base (3dc6573) to head (8a20a2b).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...configs/imviz/plugins/footprints/preset_regions.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3322      +/-   ##
==========================================
- Coverage   88.81%   88.80%   -0.02%     
==========================================
  Files         125      125              
  Lines       19041    19129      +88     
==========================================
+ Hits        16912    16988      +76     
- Misses       2129     2141      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks!

@bmorris3 bmorris3 merged commit 300e5f3 into spacetelescope:main Dec 5, 2024
19 checks passed
@kecnry kecnry mentioned this pull request Dec 10, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imviz plugin Label for plugins common to multiple configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants