Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fgs aperture threshold / sky_to_det(det_to_sky) #248

Merged

Conversation

Witchblade101
Copy link
Collaborator

Patch to try and resolve issues described in Issue #186 .

Added a custom FGS aperture threshold of 0.26 to test_jwst_aperture_transforms. Anything smaller caused an error.
Commented out the sky_to_det(det_to_sky) transform check

All generate scripts now run without errors, and all pytest tests pass.

Copy link
Collaborator

@tonysohn tonysohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will do for now. Again, the apertures causing large roundtrip errors are the ones near the edges, so it's natural that they have the largest errors. At some point, we will have to check if there is a better way to derive the inverse solutions.

@Witchblade101 Witchblade101 merged commit b136df9 into spacetelescope:master Jun 2, 2022
@Witchblade101 Witchblade101 deleted the fgs_aperture_threshold branch December 12, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants