Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versioneeer.py breaks on installation #2011

Closed
johnfmarkham opened this issue Mar 6, 2024 · 4 comments · Fixed by #2027
Closed

versioneeer.py breaks on installation #2011

johnfmarkham opened this issue Mar 6, 2024 · 4 comments · Fixed by #2027
Assignees
Labels
bug An issue with an existing feature

Comments

@johnfmarkham
Copy link

Description

Problem is described here:
EJEP/datapoint-python#183
configparser.SafeConfigParser() and parser.readfp() have been removed.

Steps/Code to Reproduce

Expected Results

Actual Results

Versions

import platform; print(platform.platform())
Linux-5.14.0-362.18.1.el9_3.x86_64-x86_64-with-glibc2.34
import sys; print("Python", sys.version)
Python 3.12.2 | packaged by Anaconda, Inc. | (main, Feb 27 2024, 17:35:02) [GCC 11.2.0]
import numpy; print("NumPy", numpy.version)
NumPy 1.26.4
import scipy; print("SciPy", scipy.version)
SciPy 1.11.4
import skimage; print("scikit-image", skimage.version)
scikit-image 0.22.0
import pandas; print("pandas", pandas.version)
pandas 2.2.1
import sklearn; print("sklearn", sklearn.version)
sklearn 1.4.1.post1
import xarray; print("xarray", xarray.version)
xarray 2024.2.0
import sympy; print("sympy", sympy.version)
sympy 1.12

@johnfmarkham johnfmarkham added the bug An issue with an existing feature label Mar 6, 2024
@berl
Copy link
Collaborator

berl commented Mar 7, 2024

@johnfmarkham want to make a PR for this? looks like that same thread suggests a fix that might work even with the current repo here

@johnfmarkham
Copy link
Author

@berl, please excuse my ignorance, what do you mean by "make a PR"?

@berl
Copy link
Collaborator

berl commented Mar 8, 2024

@johnfmarkham no problem! it's easy:

  1. fork the repo
  2. make a new branch on your fork, maybe something like 2011-fix-versioneer
  3. fix the problem, maybe using the suggestion from that thread
  4. save the changes, make a commit on your new branch and and push (to your fork). now your changes should be in a new branch on your fork of the repo on github.
  5. make a pull request from your fork to master on this repo

I'm happy to help more and there are also lots of tutorials around for this kind of workflow

@shachafl
Copy link
Collaborator

@berl @johnfmarkham I have looked into it (forked and fixed versioneer) but Starfish can't support python 3.12 because of dependency issues (numba, etc).
Once all the main dependencies support python 3.12, we can test.

@shachafl shachafl self-assigned this Oct 11, 2024
@shachafl shachafl linked a pull request Nov 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants