Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support to Python 3.12 #2027

Merged
merged 6 commits into from
Nov 12, 2024
Merged

Adding support to Python 3.12 #2027

merged 6 commits into from
Nov 12, 2024

Conversation

shachafl
Copy link
Collaborator

@shachafl shachafl commented Nov 8, 2024

This PR adds support to Python 3.12.

  1. I used python-versioneer install to update the versioneer file: https://github.com/python-versioneer/python-versioneer/blob/master/INSTALL.md
  2. Added python 3.12 to setup files
  3. Fixed some flake8 linting errors
  4. Removed some backslash sequences in python docstrings and comments as sphinx-gallery had issues converting it to reST and markdown.
  5. Added python 3.12 to starfish-prod-ci.yml

@shachafl
Copy link
Collaborator Author

shachafl commented Nov 8, 2024

@berl @njmei,
Can one of you please review this PR?
This is backward compatible, but I haven't tested on MacOS.
This closes #2011

@shachafl shachafl linked an issue Nov 12, 2024 that may be closed by this pull request
versioneeer.py breaks on installation #2011
Closed
berl
berl approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@berl berl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@shachafl shachafl merged commit a4fb226 into master Nov 12, 2024
29 checks passed
@shachafl shachafl deleted the python3.12 branch November 12, 2024 19:47
@shachafl shachafl mentioned this pull request Nov 12, 2024
Open
shachafl added a commit that referenced this pull request Dec 13, 2024
@shachafl @dependabot
updating reopened branch pypi_description for further debugging (#2044)
ad89f7d 
* Adding support to Python 3.12 (#2027)

* updating versioneer and add python 3.12 to setup files

* add python 3.12 to CI

* fix: python 3.12 flake8 linting error

* removing backslash sequences that raise SyntaxWarning in python 3.12+ when using sphinx-gallery to convert reST to markdown

* add python 3.12 support to docs

* docs: fixes to README.rst loading on PyPI project description (#2029)

* Updating CHANGELOG.md for release 0.3.1 (#2030)

* updating CHANGELOG.md for release 0.3.1

* Bump lxml-html-clean from 0.3.1 to 0.4.0 in /requirements (#2036)

Bumps [lxml-html-clean](https://github.com/fedora-python/lxml_html_clean) from 0.3.1 to 0.4.0.
- [Changelog](https://github.com/fedora-python/lxml_html_clean/blob/main/CHANGES.rst)
- [Commits](fedora-python/lxml_html_clean@0.3.1...0.4.0)

---
updated-dependencies:
- dependency-name: lxml-html-clean
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Create dependabot.yml to update Actions version (#2033)

Will automatically open PR to update:
actions/cache
actions/checkout
actions/setup-python

https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot

* replace scipy.ndimage.filters with scipy.ndimage for scipy v2 (#2035)

* Bump tornado from 6.4.1 to 6.4.2 in /requirements (#2038)

Bumps [tornado](https://github.com/tornadoweb/tornado) from 6.4.1 to 6.4.2.
- [Changelog](https://github.com/tornadoweb/tornado/blob/v6.4.2/docs/releases.rst)
- [Commits](tornadoweb/tornado@v6.4.1...v6.4.2)

---
updated-dependencies:
- dependency-name: tornado
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Github Actions auto update (#2039)

* Create dependabot.yml to update Actions version

Will automatically open PR to update:
actions/cache
actions/checkout
actions/setup-python

https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot

* moving dependabot.yml to .github/ folder

* Bump actions/checkout from 2 to 4 (#2040)

Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/cache from 2 to 4 (#2041)

Bumps [actions/cache](https://github.com/actions/cache) from 2 to 4.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v2...v4)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/setup-python from 2 to 5 (#2042)

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 2 to 5.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v2...v5)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Delete .github/workflows/dependabot.yml (#2043)

Tried to delete and remove dependabot.yml file from the wrong  folder, but this didn't register in PR #2039

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
shachafl added a commit that referenced this pull request Dec 19, 2024
@shachafl @dependabot
updating reopened branch pypi_description with master to resolve issue (
3d3b0d7 
#2046)

* Adding support to Python 3.12 (#2027)

* updating versioneer and add python 3.12 to setup files

* add python 3.12 to CI

* fix: python 3.12 flake8 linting error

* removing backslash sequences that raise SyntaxWarning in python 3.12+ when using sphinx-gallery to convert reST to markdown

* add python 3.12 support to docs

* docs: fixes to README.rst loading on PyPI project description (#2029)

* Updating CHANGELOG.md for release 0.3.1 (#2030)

* updating CHANGELOG.md for release 0.3.1

* Bump lxml-html-clean from 0.3.1 to 0.4.0 in /requirements (#2036)

Bumps [lxml-html-clean](https://github.com/fedora-python/lxml_html_clean) from 0.3.1 to 0.4.0.
- [Changelog](https://github.com/fedora-python/lxml_html_clean/blob/main/CHANGES.rst)
- [Commits](fedora-python/lxml_html_clean@0.3.1...0.4.0)

---
updated-dependencies:
- dependency-name: lxml-html-clean
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Create dependabot.yml to update Actions version (#2033)

Will automatically open PR to update:
actions/cache
actions/checkout
actions/setup-python

https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot

* replace scipy.ndimage.filters with scipy.ndimage for scipy v2 (#2035)

* Bump tornado from 6.4.1 to 6.4.2 in /requirements (#2038)

Bumps [tornado](https://github.com/tornadoweb/tornado) from 6.4.1 to 6.4.2.
- [Changelog](https://github.com/tornadoweb/tornado/blob/v6.4.2/docs/releases.rst)
- [Commits](tornadoweb/tornado@v6.4.1...v6.4.2)

---
updated-dependencies:
- dependency-name: tornado
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Github Actions auto update (#2039)

* Create dependabot.yml to update Actions version

Will automatically open PR to update:
actions/cache
actions/checkout
actions/setup-python

https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot

* moving dependabot.yml to .github/ folder

* Bump actions/checkout from 2 to 4 (#2040)

Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/cache from 2 to 4 (#2041)

Bumps [actions/cache](https://github.com/actions/cache) from 2 to 4.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v2...v4)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/setup-python from 2 to 5 (#2042)

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 2 to 5.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v2...v5)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Delete .github/workflows/dependabot.yml (#2043)

Tried to delete and remove dependabot.yml file from the wrong  folder, but this didn't register in PR #2039

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berl berl berl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Add compatibility for Python 3.12
Development

Successfully merging this pull request may close these issues.

versioneeer.py breaks on installation
2 participants
@shachafl @berl