Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping support for Python 3.8 and setting Python 3.9 as minimum #2018

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

shachafl
Copy link
Collaborator

@shachafl shachafl commented Sep 6, 2024

Due to security issues of upstream dependencies that stopped supporting Python 3.8, such as scikit-learn, etc.
I have updated requirements files, texts and others to support this update.

This PR should also close PR #2015

@shachafl shachafl requested a review from berl September 6, 2024 18:24
@shachafl shachafl marked this pull request as draft September 6, 2024 18:26
@shachafl shachafl marked this pull request as ready for review September 6, 2024 21:13
Copy link
Collaborator

@berl berl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. I ran pytest on this on an M1 mac and it also passed with
====== 372 passed, 3 skipped, 8 deselected, 65 warnings in 1165.18s (0:19:25) ====
I made one minor comment above but otherwise ready to merge.

README.rst Show resolved Hide resolved
@shachafl shachafl merged commit ec2697c into spacetx:master Sep 9, 2024
25 checks passed
@shachafl shachafl deleted the py3.9 branch September 9, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants