Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numpy 1.26 update to support Python 3.12 #2025

Merged
merged 4 commits into from
Oct 12, 2024
Merged

Numpy 1.26 update to support Python 3.12 #2025

merged 4 commits into from
Oct 12, 2024

Conversation

shachafl
Copy link
Collaborator

@shachafl shachafl commented Oct 11, 2024 •
edited
Loading

@shachafl shachafl force-pushed the numpy1.26 branch 2 times, most recently from 9c63825 to 60af531 Compare October 11, 2024 17:57
@shachafl
Copy link
Collaborator Author

@berl , @njmei , can one of you please review this PR?

njmei
njmei approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@njmei njmei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patience, this looks fine to me.

@shachafl shachafl merged commit c3b3edb into master Oct 12, 2024
25 checks passed
@shachafl shachafl deleted the numpy1.26 branch October 12, 2024 01:12
@shachafl shachafl restored the numpy1.26 branch November 14, 2024 20:56
@shachafl shachafl deleted the numpy1.26 branch November 14, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njmei njmei njmei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Add compatibility for Python 3.12
Development

Successfully merging this pull request may close these issues.

Update numpy in REQUIREMENTS.txt for compatibility with Python 3.12
2 participants
@shachafl @njmei