Missing pypi description fix by adding pyproject.toml #2047
+73
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing pypi description fix by adding pyproject.toml Verified solution by uploading to testpypi after build: `python3 -m twine upload --repository testpypi dist/*` Will be resolved on master branch after new release is made and uploaded. Reference: https://packaging.python.org/en/latest/guides/modernize-setup-py-project/ https://packaging.python.org/en/latest/guides/writing-pyproject-toml/ https://packaging.python.org/en/latest/specifications/pyproject-toml/ https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2028.
Missing pypi description fix by adding pyproject.toml
Verified solution by uploading to testpypi after build:
python3 -m twine upload --repository testpypi dist/*Result: https://test.pypi.org/project/starfish/0.3.2rc1/
Will be resolved on master branch after new release is made and uploaded.
Summary of commits:
adding pyproject.toml and removing setup.cfg
adding package "build" to requirements files (and other minor dependencies update)
replaced deprecated
python setup.py sdistwithpython -m buildin MakefileReference:
https://packaging.python.org/en/latest/guides/modernize-setup-py-project/
https://packaging.python.org/en/latest/guides/writing-pyproject-toml/
https://packaging.python.org/en/latest/specifications/pyproject-toml/
https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html