-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve warning which indicate state changed after widget disposed #125
Conversation
Codecov Report
@@ Coverage Diff @@
## main #125 +/- ##
==========================================
+ Coverage 26.91% 27.36% +0.45%
==========================================
Files 80 80
Lines 4708 4707 -1
==========================================
+ Hits 1267 1288 +21
+ Misses 3441 3419 -22
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bac7027
to
588c43f
Compare
3070302
to
7f3c4d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
String 대신 Enum을 활용하여 코드가 더 견고해 진 것 같습니다 수고하셨어요 :)
7f3c4d7
to
bb9b014
Compare
Changes
by using ValueNotifier instead of setState to notify widgets that needs rebuild
Issue
To Reproduce
시간표 검색결과 화면 닫기 버튼을 빠르게 눌렀다 뗄 경우 GestureDetector의 onTapDown 함수의 delayed computation에서 실행되는 setState이 IconTextButton가 disposed 된 후에 실행되면서 Warning 메시지를 띄움
Fix Procedure
setState를 mounted된 경우에만 실행하는 것으로 해결 c8e53ab