Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #115, Fix infinite loading if maximum scrolled #175

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

RGLie
Copy link
Contributor

@RGLie RGLie commented Apr 3, 2024

Description

Fixed infinite loading circular progress indicator if maximum scrolled.
기존 코드가 Latest Review, Hall of Fame Review에도 똑같이 되어 있어 같은 방식으로 수정했습니다.

Screenshots

@RGLie RGLie added the bug Something isn't working label Apr 3, 2024
@RGLie RGLie requested a review from sboh1214 April 3, 2024 04:37
@RGLie RGLie self-assigned this Apr 3, 2024
@RGLie RGLie linked an issue Apr 3, 2024 that may be closed by this pull request
@github-actions github-actions bot added the size/s label Apr 3, 2024
@RGLie RGLie marked this pull request as draft April 3, 2024 04:38
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 31.16%. Comparing base (9d99f22) to head (47256c8).

Files Patch % Lines
lib/pages/review_page.dart 0.00% 10 Missing ⚠️
lib/pages/liked_review_page.dart 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
- Coverage   31.19%   31.16%   -0.04%     
==========================================
  Files          80       80              
  Lines        4811     4817       +6     
==========================================
  Hits         1501     1501              
- Misses       3310     3316       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RGLie RGLie marked this pull request as ready for review April 3, 2024 04:51
Copy link
Contributor

@sboh1214 sboh1214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

<PM님의 전언>
따끈따끈 과목 후기, 명예의 전당은 후기 수가 너무 많아서 테스트 못 해봤지만 .. 좋아요한 후기에서 정상적으로 동작하는 것 확인했습니다! 수고하셨어요 👍

@sboh1214 sboh1214 merged commit ad2294c into main Apr 4, 2024
6 of 8 checks passed
@sboh1214 sboh1214 deleted the bug@infinite-loading-maximum-scroll branch April 4, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Infinite loading if maximum scrolled
2 participants