feat: department-options, favorite-departments API #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddungiii
reviewed
Feb 13, 2024
Comment on lines
89
to
93
| const res = (await this.prisma.$queryRaw` | ||
| SELECT DISTINCT d.code | ||
| FROM subject_lecture l | ||
| JOIN subject_department d on l.department_id = d.id | ||
| WHERE l.year >= ${yearThreshold};`) as { code: string }[]; |
There was a problem hiding this comment.
raw query로 해결해야하는 이유가 있을까요?
distinct가 사용이 안되나요??
There was a problem hiding this comment.
include된 필드에는 distinct가 안된다고 본 것 같아서 이렇게 했는데 다시 보니 distinct도 안 쓰고 가능한 방법이 있어서 고쳤습니다.
ddungiii
approved these changes
Feb 14, 2024
| ), | ||
| ]); | ||
|
|
||
| console.log('recentDepartmentCodes', recentDepartmentCodes); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
리뷰 필요 사항