Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate all basic ui components #82

Open
wants to merge 1 commit into
base: migration
Choose a base branch
from

Conversation

useruseruse
Copy link
Contributor

Description

  • Scroller, Divider 등 UI 컴포넌트들의 마이그레이션을 진행했습니다.
  • migration@utils 브랜치 위에서 작업하여 함께 머지되면 좋을 것 같아요.

Checklist

테스트

@useruseruse useruseruse self-assigned this Sep 16, 2024
@useruseruse useruseruse added the migrate migrate from JS CC to TS FC label Sep 16, 2024
Base automatically changed from migration@utils to migration September 18, 2024 21:19
@useruseruse useruseruse reopened this Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 13.29787% with 163 lines in your changes missing coverage. Please review.

Project coverage is 6.52%. Comparing base (3cb4ddd) to head (311d23a).
Report is 1 commits behind head on migration.

Files with missing lines Patch % Lines
src/components/CreditBar.tsx 0.00% 29 Missing and 1 partial ⚠️
src/components/Scroller.tsx 0.00% 26 Missing and 1 partial ⚠️
src/components/SearchFilter.tsx 20.58% 27 Missing ⚠️
src/components/Divider.tsx 0.00% 17 Missing ⚠️
src/components/BetaPopup.tsx 0.00% 11 Missing and 1 partial ⚠️
src/components/SearchFilterEntity.tsx 23.07% 10 Missing ⚠️
src/components/CountController.tsx 0.00% 8 Missing and 1 partial ⚠️
src/components/OtlplusPlaceholder.tsx 0.00% 8 Missing ⚠️
src/components/CourseStatus.tsx 0.00% 6 Missing ⚠️
src/components/Scores.tsx 0.00% 6 Missing ⚠️
... and 5 more
Additional details and impacted files
@@             Coverage Diff              @@
##           migration     #82      +/-   ##
============================================
+ Coverage       6.36%   6.52%   +0.16%     
============================================
  Files            206     206              
  Lines           6285    6298      +13     
  Branches        1649    1650       +1     
============================================
+ Hits             400     411      +11     
+ Misses          5783    5779       -4     
- Partials         102     108       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migrate migrate from JS CC to TS FC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant