Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skeleton directory 내 typescript 전환 #420

Merged
merged 7 commits into from
Dec 2, 2022

Conversation

GrasshopperBears
Copy link
Contributor

Summary

연관 이슈: #419

/src/components/Skeleton/ 내 컴포넌트를 typescript로 전환했습니다.

Images or Screenshots

화면 변경 없음

@GrasshopperBears GrasshopperBears added the 🔨refactoring 기존의 코드를 리팩토링합니다 label Nov 29, 2022
@GrasshopperBears GrasshopperBears self-assigned this Nov 29, 2022
@14KGun 14KGun added the skeleton label Dec 1, 2022
@14KGun 14KGun linked an issue Dec 1, 2022 that may be closed by this pull request
2 tasks
Copy link
Member

@14KGun 14KGun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 ~

Comment on lines -3 to -9
class Footer extends Component {
render() {
return (
<div style={{ height: "calc(88px + env(safe-area-inset-bottom))" }}></div>
);
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헐 얘 class 였군요 ㅋㅋㅋ

Copy link
Contributor

@imYourChoi imYourChoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻👍🏻

@GrasshopperBears GrasshopperBears merged commit 1794e33 into main Dec 2, 2022
@GrasshopperBears GrasshopperBears deleted the refactor/#419-refactor-skeleton-ts branch December 2, 2022 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨refactoring 기존의 코드를 리팩토링합니다 skeleton
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript 점진적 도입
3 participants