#394 마이페이지에 알림 설정 추가 + Introduce @emotion/react
#488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
…-kaist/taxi-front into #394-notification-setting
Open
2 tasks
14KGun
changed the title
@emotion/react
14KGun
commented
Mar 30, 2023
| @@ -1,3 +1,4 @@ | |||
| node_modules | |||
| build | |||
| .github | |||
| tsconfig.json | |||
There was a problem hiding this comment.
tsconfig.json formatting은 typescript가 자동으로 해주더라고요.
Comment on lines
+14
to
+22
| babel: { | ||
| presets: [ | ||
| [ | ||
| "@babel/preset-react", | ||
| { runtime: "automatic", importSource: "@emotion/react" }, | ||
| ], | ||
| ], | ||
| plugins: ["@emotion/babel-plugin"], | ||
| }, |
There was a problem hiding this comment.
css prop 에 대해서 babel 설정하였습니다.
There was a problem hiding this comment.
react-mobile-picker-mod는 과거에 사용한 모듈로 현재는 taxi-front에서 사용하지 않습니다.
해당 모듈의 type정의를 지웠습니다.
14KGun
commented
Mar 31, 2023
Comment on lines
+1
to
+10
| import { atom } from "recoil"; | ||
|
|
||
| export type deviceTokenType = Nullable<string>; | ||
|
|
||
| const deviceTokenAtom = atom<deviceTokenType>({ | ||
| key: "deviceTokenAtom", | ||
| default: null, | ||
| }); | ||
|
|
||
| export default deviceTokenAtom; |
There was a problem hiding this comment.
deviceToken 을 관리하기 위한 recoil state를 정의하였습니다.
Comment on lines
+1
to
+16
| import { atom } from "recoil"; | ||
|
|
||
| export type notificationOptionsType = { | ||
| advertisement: boolean; | ||
| beforeDepart: boolean; | ||
| chatting: boolean; | ||
| notice: boolean; | ||
| keywords: [string]; | ||
| }; | ||
|
|
||
| const notificationOptionsAtom = atom<Nullable<notificationOptionsType>>({ | ||
| key: "notificationOptionsAtom", | ||
| default: null, | ||
| }); | ||
|
|
||
| export default notificationOptionsAtom; |
There was a problem hiding this comment.
notificationOption(/notifications/options API 호출 결과) 을 관리하기 위한 recoil state를 정의하였습니다.
| url: "/auth/registerDeviceToken", | ||
| method: "post", | ||
| data: { deviceToken: newDeviceToken }, | ||
| onSuccess: () => setDeviceToken(newDeviceToken), |
There was a problem hiding this comment.
device 토큰 등록을 taxi-back에 API를 통해 완료하면, global state를 업데이트 합니다.
Comment on lines
+116
to
+140
| <NavigationMenu | ||
| text={t("home_for_nav", { ns: "home" })} | ||
| page="home" | ||
| path={pathname} | ||
| /> | ||
| <NavigationMenu | ||
| text={t("search_room_for_nav", { ns: "search" })} | ||
| page="search" | ||
| path={pathname} | ||
| /> | ||
| <NavigationMenu | ||
| text={t("add_room_for_nav", { ns: "addroom" })} | ||
| page="addroom" | ||
| path={pathname} | ||
| /> | ||
| <NavigationMenu | ||
| text={t("my_room_for_nav", { ns: "myroom" })} | ||
| page="myroom" | ||
| path={pathname} | ||
| /> | ||
| <NavigationMenu | ||
| text={t("my_page_for_nav", { ns: "mypage" })} | ||
| page="mypage" | ||
| path={pathname} | ||
| /> |
There was a problem hiding this comment.
Navigation 컴포넌트 i18n으로 영어 지원
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It closes #394 , #495
Screenshots
알림 기능 설정 모달
디바이스 토큰을 백엔드에서 확인할 수 없을 때