Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#592 공유하기 링크의 OG image URL 수정 #593

Merged
merged 4 commits into from
Jul 20, 2023
Merged

Conversation

14KGun
Copy link
Member

@14KGun 14KGun commented Jul 14, 2023

Summary

It closes #592

@14KGun 14KGun added the ⚒ enhancement New feature or request label Jul 14, 2023
@14KGun 14KGun self-assigned this Jul 14, 2023
@14KGun 14KGun linked an issue Jul 14, 2023 that may be closed by this pull request
@14KGun 14KGun marked this pull request as ready for review July 19, 2023 07:43
@14KGun 14KGun linked an issue Jul 19, 2023 that may be closed by this pull request
2 tasks
@@ -1,6 +1,6 @@
import PropTypes from "prop-types";
import { useEffect, useRef, useState } from "react";
import { useHistory } from "react-router";
import { useHistory } from "react-router-dom";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/sparcs-kaist/taxi-front/pull/590/files#r1260842566

@cokia 님께서 이전에 PR에 반영하셨던 내용이라 conflict 날 수 있을 것 같아요

Copy link
Member

@withSang withSang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아보여요!! 감사합니다 :)

@14KGun 14KGun merged commit 5cdfefa into dev Jul 20, 2023
@14KGun 14KGun deleted the #592-invite-og-uri branch July 20, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚒ enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript 점진적 도입 공유하기 링크의 OG image URL 수정
2 participants