Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

리더보드 만들기 #731

Merged
merged 10 commits into from
Feb 19, 2024
Merged

Conversation

ybmin
Copy link
Contributor

@ybmin ybmin commented Feb 18, 2024

Summary

It closes #727

Images or Screenshots

그림2

Further Work

  • 사소한 스타일링을 논의 후 결정해야합니다. (닉네임 텍스트 truncated 여부, 코인 텍스트 너비 고정 여부)
  • 백엔드 변경? (MVP 정보를 전해줘야합니다.)
    { "leaderboard": [ { "group": 16, "creditAmount": 16000, "nickname": "넙죽이", "profileImageUrl": "" } ], "group": 16, "rank": 1 }
    대략적으로 이런 형식이면 되지 않을까해서 적어놓았고, 일단 위에 기술한 형식대로 출력하도록 구현하였습니다.

@ybmin ybmin added 🖥 working 아직 작업 중인 상태 event labels Feb 18, 2024
@ybmin ybmin self-assigned this Feb 18, 2024
@ybmin ybmin linked an issue Feb 18, 2024 that may be closed by this pull request
Copy link

netlify bot commented Feb 18, 2024

Deploy Preview for taxi-dev-preview ready!

Name Link
🔨 Latest commit 03294da
🔍 Latest deploy log https://app.netlify.com/sites/taxi-dev-preview/deploys/65d359d822c593000859d4d3
😎 Deploy Preview https://deploy-preview-731--taxi-dev-preview.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ybmin
Copy link
Contributor Author

ybmin commented Feb 18, 2024

API에서 필드명이 각각 nickname -> mvpNickname, profileImageUrl -> mvpProfileImageUrl 으로 변경되었습니다.
백엔드 @kmc7468 님 수고하셨습니다!

@14KGun
Copy link
Member

14KGun commented Feb 18, 2024

@ybmin @kmc7468 이거 Backend API 수정 필요하다고 하셨는데, 반영된걸까요??

@kmc7468
Copy link
Member

kmc7468 commented Feb 18, 2024

@14KGun 넵, 백엔드에 반영된 상태입니다!

image

<ButtonAboveFooter text="택시 살펴보기" />
</Link>
<ButtonAboveFooter
text="새터반 택시대대전를 만든 사람들"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엇 여기 오타 있는 것 같아요! 택시대제전이라고 수정이 되어야 할 것 같습니다. 그리고 클릭하면 아래 이미지와 같이 아무 것도 안뜨네요 ㅜ

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일어나서 바로 수정해놓겠습니다! 감사합니다

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추가 완료했습니다!

Copy link
Member

@14KGun 14KGun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

{
position: "⚙️ Front-end Developer",
list: [
{ name: "김건", id: "suwon", period: "2024" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저 빼주셔도 됩니다 ㅎㅎ

@ybmin ybmin merged commit 68b4dd7 into dev Feb 19, 2024
4 checks passed
@ybmin ybmin deleted the #727-2024-봄-이벤트-리더보드-만들기 branch February 19, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
event 🖥 working 아직 작업 중인 상태
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2024 봄 이벤트 리더보드 만들기
3 participants