Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
✅ Deploy Preview for taxi-dev-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
14KGun
reviewed
Feb 19, 2024
packages/web/src/components/Event/CreditAmoutContainer/index.tsx
Outdated
Show resolved
Hide resolved
packages/web/src/components/Event/SuggestJoinEventContainer/index.tsx
Outdated
Show resolved
Hide resolved
packages/web/src/components/Event/SuggestJoinEventContainer/index.tsx
Outdated
Show resolved
Hide resolved
14KGun
reviewed
Feb 19, 2024
Comment on lines
7
to
12
| completedQuests: QuestId[]; | ||
| creditAmount: number; | ||
| groupCreditAmount: number; | ||
| group: number; | ||
| ticket1Amount: number; | ||
| ticket2Amount: number; |
There was a problem hiding this comment.
추후에 이벤트 참가 가능 여부가 event2024SpringInfo API 에 담겨져서 넘어 올 것 같습니다.
이 값에 따라 이벤트 상태, 이벤트 참여 권장 컴포넌트 띄어지도록 수정되어야 할 것 같아요
| @@ -3,6 +3,7 @@ import theme from "@/tools/theme"; | |||
| type ButtonAboveFooterProps = { | |||
| text: string; | |||
| onClick?: () => void; | |||
| isWhite?: boolean; | |||
| useEffect(() => { | ||
| const prevBackground = document.body.style.background; | ||
| document.body.style.background = color; | ||
| // return () => document.body.style.background = prevBackground; |
Comment on lines
6
to
8
| export const useEventBackgroundEffect = ({ | ||
| color = "#000000", | ||
| }: EventBackgroundEffectProps) => { |
There was a problem hiding this comment.
컴포넌트가 아니라서 props 명칭 사용이 부적절해보입니다 ㅜ
| left: 0, | ||
| width: "8px", | ||
| background: isDone ? theme.purple_disabled : theme.purple, | ||
| backgroundColor: "#000", |
There was a problem hiding this comment.
useEventBackgroundColorEffect Hook의 사용으로 backgroundColor: "#000", 지우서도 될 것 같습니다 !
| <div css={styleRewardText}> | ||
| {questCompletedCnt}회 달성 (최대 {quest.maxCount}회) | ||
| </div> | ||
| <div css={{ flexGrow: 1 }} /> |
There was a problem hiding this comment.
Suggested change
| <div css={{ flexGrow: 1 }} /> | |
| <div css={{ flexGrow: 1, width: 0 }} /> |
| </WhiteContainer> | ||
| ); | ||
| }; | ||
|
|
||
| const Event2024SpringMissions = () => { | ||
| const { quests } = useValueRecoilState("event2023FallInfo") || {}; | ||
| const { quests } = useValueRecoilState("event2024SpringInfo") || {}; | ||
| useEventBackgroundEffect({ color: "#000000" }); |
| <> | ||
| <div | ||
| css={{ | ||
| background: eventTheme.black, |
There was a problem hiding this comment.
이것두 useEventBackgroundEffect 있어서 <></> 사용으로 수정 가능해 보입니다.!
14KGun
approved these changes
Feb 19, 2024
| ); | ||
| }; | ||
|
|
||
| export default SuggestJoinEventContainer; |
There was a problem hiding this comment.
Suggested change
| export default SuggestJoinEventContainer; | |
| export default memo(SuggestJoinEventContainer); |
메모이제이션 권장 드립니다.!
| @@ -0,0 +1,11 @@ | |||
| import { useEffect } from "react"; | |||
|
|
|||
| export const useEventBackgroundEffect = (color: string = "#000000") => { | |||
There was a problem hiding this comment.
CSSProperties.background type 사용 가능합니다 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It closes #728
Images or Screenshots