Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#733 2024 봄학기 홈화면 만들기 #734

Merged
merged 19 commits into from
Feb 19, 2024

Conversation

predict-woo
Copy link
Member

Summary

It closes #733

Images or Screenshots

Further Work

@predict-woo predict-woo self-assigned this Feb 19, 2024
@predict-woo predict-woo linked an issue Feb 19, 2024 that may be closed by this pull request
Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for taxi-dev-preview ready!

Name Link
🔨 Latest commit 341e2cc
🔍 Latest deploy log https://app.netlify.com/sites/taxi-dev-preview/deploys/65d36d91ee8d4800085ef04a
😎 Deploy Preview https://deploy-preview-734--taxi-dev-preview.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

packages/web/src/pages/Event/Event2024Spring.tsx Outdated Show resolved Hide resolved
packages/web/src/pages/Event/Event2024Spring.tsx Outdated Show resolved Hide resolved
packages/web/src/pages/Event/Event2024Spring.tsx Outdated Show resolved Hide resolved
packages/web/src/pages/Event/Event2024Spring.tsx Outdated Show resolved Hide resolved
background: "#FFF",
};
const styleVerticalCenter = {
display: "flex",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
display: "flex",
display: "flex" as const,

제안 드립니다.~

<>
<div
css={{
backgroundColor: eventTheme.black,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eventTheme.black 를 나중에 @pbc1017 께서 작업 중이신 useBackgroundColorEffect 사용하면 해결될 것 같습니다. ~

Copy link
Member

@14KGun 14KGun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 👍 LGTM

packages/web/src/pages/Event/Event2024Spring.tsx Outdated Show resolved Hide resolved
@predict-woo predict-woo merged commit 012b747 into dev Feb 19, 2024
4 checks passed
@predict-woo predict-woo deleted the #733-2024-spring-create-event-home branch February 19, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2024 봄 이벤트 홈 페이지 만들기
2 participants