Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024 봄학기 이벤트 리더보드 이벤트 테마 코드 사용 #736

Merged
merged 8 commits into from
Feb 21, 2024

Conversation

ybmin
Copy link
Contributor

@ybmin ybmin commented Feb 19, 2024

Summary

It closes #735
이벤트 테마 코드를 사용하도록, 테마코드를 활용하고 없는 폰트에 대해서는 파일을 추가했습니다.
그리고 리더보드 정렬 함수에서 놓친 케이스가 있어서 해당 경우를 처리하도록 수정했습니다.

Further Work

  • 병찬님 코드 스타일처럼 hook으로 배경색을 검정으로 변경하도록 코드를 바꿔야 합니다. (이것은 병찬님 브랜치 머지 후에 작업하겠습니다)

@ybmin ybmin added 🔨refactoring 기존의 코드를 리팩토링합니다 event labels Feb 19, 2024
@ybmin ybmin self-assigned this Feb 19, 2024
@ybmin ybmin linked an issue Feb 19, 2024 that may be closed by this pull request
Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for taxi-dev-preview ready!

Name Link
🔨 Latest commit fc20dda
🔍 Latest deploy log https://app.netlify.com/sites/taxi-dev-preview/deploys/65d4b21b97921c00081c8437
😎 Deploy Preview https://deploy-preview-736--taxi-dev-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ybmin ybmin marked this pull request as draft February 19, 2024 15:18
@ybmin ybmin added the 🖥 working 아직 작업 중인 상태 label Feb 19, 2024
@ybmin ybmin marked this pull request as ready for review February 20, 2024 14:07
Copy link
Member

@14KGun 14KGun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !
수고하셨습니다 ~ 😄

@ybmin ybmin merged commit 1cff0e0 into dev Feb 21, 2024
4 checks passed
@ybmin ybmin deleted the #735-리더보드-이벤트-테마-사용 branch February 21, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
event 🔨refactoring 기존의 코드를 리팩토링합니다 🖥 working 아직 작업 중인 상태
Projects
None yet
Development

Successfully merging this pull request may close these issues.

리더보드 이벤트 테마 사용
2 participants