Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
✅ Deploy Preview for taxi-dev-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
수고하셨습니다! 다만 추천인 항목의 경우 사용자가 직접 입력하는 항목이 아닙니다. 자세한 내용은 노션에 있는 추천인 시스템 구현 아이디어 문서 참고 부탁드려요! 간략하게 설명드리면, 초대 URL을 통해 넘어온 경우 추천인 정보가 표시되어야 하고, 그렇지 않은 경우 초대 퀘스트가 있음을 안내하는 내용이 표시되어야 합니다. |
kmc7468
reviewed
Feb 22, 2024
| @@ -17,7 +17,6 @@ const SuggestJoinEventContainer = () => { | |||
| const { isAgreeOnTermsOfEvent, completedQuests } = | |||
| useValueRecoilState("event2024SpringInfo") || {}; | |||
|
|
|||
| const randomToken = useMemo(() => !!Math.floor(Math.random() * 2), []); | |||
There was a problem hiding this comment.
지난 가을학기 때 쓰였던 WhiteContainerSuggestJoinEvent 코드와 비교하며 읽어보니, randomToken은 띄워야 할 컨테이너 종류가 여러 개였어서 그 중 하나를 랜덤으로 띄우기 위해 쓰였던 값 같습니다. 이번 봄학기 때에는 그럴 필요가 없어서, 관련 코드를 모두 삭제했습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModalEvent2024SpringJoin 파일을 신규 생성하고 전화번호, 새터반, 추천인을 입력할 수 있도록 수정했습니다.
SuggestJoinEventContainer에서 ModalEvent2024SpringJoin을 불러오도록 수정했습니다.