Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024 봄학기 이벤트 방 생성시 경고 모달 #745

Merged
merged 10 commits into from
Feb 23, 2024

Conversation

ybmin
Copy link
Contributor

@ybmin ybmin commented Feb 22, 2024

Summary

It closes #744

Images or Screenshots

image
image

Further Work

  • 퀘스트 호출 관련 함수들에 대한 수정이 필요합니다.
  • 기타 같은 파일에서 작업하여 충돌이 예상됩니다. 다른 PR(퀘스트 관련 작업)들이 머지된 이후 충돌 해결하여 리뷰 요청 및 머지 올리겠습니다

@ybmin ybmin added 🖥 working 아직 작업 중인 상태 event labels Feb 22, 2024
@ybmin ybmin self-assigned this Feb 22, 2024
@ybmin ybmin linked an issue Feb 22, 2024 that may be closed by this pull request
Copy link

netlify bot commented Feb 22, 2024

Deploy Preview for taxi-dev-preview ready!

Name Link
🔨 Latest commit 146655a
🔍 Latest deploy log https://app.netlify.com/sites/taxi-dev-preview/deploys/65d85bda0a5fff0008ce0861
😎 Deploy Preview https://deploy-preview-745--taxi-dev-preview.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ybmin ybmin changed the title Add: event 2024 spring abuse warning page 2024 봄학기 이벤트 방 생성시 경고 모달 Feb 22, 2024
@ybmin
Copy link
Contributor Author

ybmin commented Feb 22, 2024

일단 이벤트 훅이 연결 되어있는 브랜치를 찾지 못해 방 첫번째 생성에 대한 퀘스트는 연결해 놓았습니다
추후 진행 상황을 적용하도록 하겠습니다

@kmc7468 kmc7468 marked this pull request as ready for review February 23, 2024 08:42
@kmc7468 kmc7468 merged commit c02564f into dev Feb 23, 2024
4 checks passed
@kmc7468 kmc7468 deleted the #744-2024-봄학기-이벤트-방-생성시-경고-모달 branch February 23, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
event 🖥 working 아직 작업 중인 상태
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2024 봄학기 이벤트 방 생성시 경고 모달
2 participants