Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

채팅 endpoint 오류 수정 #765

Merged
merged 5 commits into from
May 28, 2024
Merged

Conversation

jinhyeonkwon
Copy link
Contributor

Summary

It closes #763

송금 관련 API가 /rooms/commitSettlement
정산 관련 API가 /rooms/commitPayment
이렇게 이름이 뒤바뀐 오류가 있었습니다.
이에 taxi-back 에서 이를 바로잡았고 (sparcs-kaist/taxi-back#460), 이 PR에서는 이 수정사항에 맞추어 Front 측의 API 호출을 바꾸게 되었습니다.

@jinhyeonkwon jinhyeonkwon self-assigned this Mar 19, 2024
@jinhyeonkwon jinhyeonkwon linked an issue Mar 19, 2024 that may be closed by this pull request
Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for taxi-dev-preview ready!

Name Link
🔨 Latest commit 02ccdc7
🔍 Latest deploy log https://app.netlify.com/sites/taxi-dev-preview/deploys/6655e5f3efb16b0007aacf97
😎 Deploy Preview https://deploy-preview-765--taxi-dev-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jinhyeonkwon
Copy link
Contributor Author

ModalChatPayment.tsx와 ModalChatSettlement.tsx에서 각각 onClickOk에서 사용하는 axios 코드만 수정했습니다. 레포 전체 코드 검색에서 commitSettlement 또는 commitPayment라는 키워드가 나타나는 부분이 해당 부분밖에 없어서 이렇게 했는데, 제가 혹시 놓친 부분이 있는지 봐주시면 감사하겠습니다.

@jinhyeonkwon jinhyeonkwon changed the title Fix: modify axios url for payment and settlement (sync to backend mod… 채팅 endpoint 오류 수정 Mar 19, 2024
Copy link
Contributor

@ybmin ybmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

@GKim67 GKim67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@predict-woo predict-woo self-assigned this May 28, 2024
@predict-woo predict-woo merged commit 7acf06a into dev May 28, 2024
4 checks passed
@predict-woo predict-woo deleted the #763-채팅-endpoint-오류-수정 branch May 28, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

채팅 endpoint 오류 수정
6 participants