-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
채팅 endpoint 오류 수정 #765
The head ref may contain hidden characters: "#763-\uCC44\uD305-endpoint-\uC624\uB958-\uC218\uC815"
채팅 endpoint 오류 수정 #765
Conversation
✅ Deploy Preview for taxi-dev-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ModalChatPayment.tsx와 ModalChatSettlement.tsx에서 각각 onClickOk에서 사용하는 axios 코드만 수정했습니다. 레포 전체 코드 검색에서 commitSettlement 또는 commitPayment라는 키워드가 나타나는 부분이 해당 부분밖에 없어서 이렇게 했는데, 제가 혹시 놓친 부분이 있는지 봐주시면 감사하겠습니다. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Summary
It closes #763
송금 관련 API가 /rooms/commitSettlement
정산 관련 API가 /rooms/commitPayment
이렇게 이름이 뒤바뀐 오류가 있었습니다.
이에 taxi-back 에서 이를 바로잡았고 (sparcs-kaist/taxi-back#460), 이 PR에서는 이 수정사항에 맞추어 Front 측의 API 호출을 바꾸게 되었습니다.