Add: room diff calculation #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
✅ Deploy Preview for taxi-dev-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
GKim67
reviewed
Mar 27, 2024
| props.rooms && | ||
| localRooms?.length && | ||
| (props.rooms.length !== localRooms.length || | ||
| JSON.stringify(props.rooms) !== JSON.stringify(localRooms.length)) |
There was a problem hiding this comment.
잉 JSON.stringify(props.rooms) !== JSON.stringify(localRooms.length) 이거 뭐죠...???
There was a problem hiding this comment.
어떤 이유에서 작성된 코드인지는 몰라도.. 좋은 해결책처럼 보이지는 않습니다 ㅜ
| useEffect(() => { | ||
| const interval = setInterval(fetchAllRooms, 1000 * 60 * 5); | ||
| const interval = setInterval(fetchAllRooms, 1000 * 10); |
There was a problem hiding this comment.
10초마다 backend에 API request 를 날리는 군요 ㅜㅜㅜ
우리 서버 힘들겠군.. ㅜ
useSWR 이나 useQuery 쓰면 인터벌 하게 API 값 갱신하는 것 수동으로 안해줘도 될듯요?
…om and Home pages
jinhyeonkwon
approved these changes
May 14, 2024
jyjy1229
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It closes #768
Images or Screenshots
Further Work