Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for taxi-dev-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jinhyeonkwon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It closes #798
Room컴포넌트에서, 방 이름에 해당하는 스타일과 인원 수 태그에 해당하는 스타일을 고쳐서,설정하여 태그는 원래의 크기를 항상 유지하며, 방 이름이 카드 크기나 방 이름의 길이에 맞추어 줄어들도록 하였습니다.
Images or Screenshots
Further Work
테스트를 위해 긴 이름의 방을 생성할 때, 우리가 채팅창에서 긴 채팅은 아예 입력되지 않게 한 것처럼 방 이름도 입력하는 칸에서부터 글자 수 제한을 적용하면 어떨까 합니다 (현재는 올바르지 않은 방 이름이라고 생성 버튼이 비활성화되는 방식입니다)